Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config argument to getAccessTokenWithPopup #141

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Add config argument to getAccessTokenWithPopup #141

merged 1 commit into from
Oct 27, 2020

Conversation

ygist
Copy link
Contributor

@ygist ygist commented Oct 26, 2020 •
edited
Loading

Description

Add workaround config argument to getAccessTokenWithPopup to work with iOS, similar to loginWithPopup.

References

auth0/auth0-spa-js#368

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@ygist
Add config argument to getAccessTokenWithPopup
aea87dd 
for use with iOS to open a popup, similar to loginWithPopup.

refer to auth0/auth0-spa-js#368 for additional details
@ygist ygist requested a review from a team October 26, 2020 23:38
@adamjmcgrath adamjmcgrath merged commit e9202ac into auth0:master Oct 27, 2020
@adamjmcgrath
Copy link
Contributor

Thanks @ygist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ygist @adamjmcgrath