Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-1927] Check for state param in callback url #107

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

adamjmcgrath
Copy link
Contributor

Description

Because SPA JS always sends a state param to /authorize, we can always assume that a valid redirect callback will contain both state and code.

Doing this will reduce the chance of collisions when the application is using the code param for something unrelated to auth.

References

Might mitigate some cases of #75

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath added the small This PR may require low effort to action, or contains few changes to review label Sep 2, 2020
@adamjmcgrath adamjmcgrath requested a review from a team September 2, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small This PR may require low effort to action, or contains few changes to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants