Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Angular Above 13 #617

Closed
wants to merge 1 commit into from

Conversation

PuriaRad
Copy link

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Support for Angular above 13

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • Auth0 Community post
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@PuriaRad PuriaRad requested a review from a team as a code owner June 18, 2024 08:52
@PuriaRad PuriaRad changed the title add-support-angular-above-13 Add support Angular Above 13 Jun 18, 2024
@frederikprijck
Copy link
Member

We have support for the anything above v13 in v2 our SDK, is there any reason you are not using v2 of our SDK?

@PuriaRad
Copy link
Author

We have support for the anything above v13 in v2 our SDK, is there any reason you are not using v2 of our SDK?

We have a legacy project and it's impossible to update the version to 2 (spent hours and tried almost everything). That's why I created the PR. Please help me on this.

@PuriaRad PuriaRad changed the title Add support Angular Above 13 Add support for Angular Above 13 Jun 18, 2024
@frederikprijck
Copy link
Member

frederikprijck commented Jun 20, 2024

We have a legacy project and it's impossible to update the version to 2 (spent hours and tried almost everything)

What's the problem you are facing? i recommend opening an issue so we can discuss. Happy to help you move over to v2, but we have no plans to add support for Angular 13 in v1 of our SDK. But you are always free to fork, and update as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants