Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for Angular 17 #616

Closed
wants to merge 133 commits into from

Conversation

PuriaRad
Copy link

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

We are using [email protected] and cannot update it to version 2 (we tried a lot but many things are missing). So, in this pull request, I added the support for higher versions of Angular.

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • Auth0 Community post
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

frederikprijck and others added 30 commits January 19, 2023 13:49
* Use latest version of SPA-JS

* fix tests
* Change support to anything above the current lowest LTS version

* Run ng update to update to 13

* Use ESLint instead of TSLint

* Fix lint issues introduced by migrating to es lint

* Update karma to use karma-coverage

* fix coverage path
* Strict check for URL params

* Strict check for URL param - add tests

* Update projects/auth0-angular/src/lib/auth.service.ts

* Fix compilation

Co-authored-by: Frederik Prijck <[email protected]>
Co-authored-by: Frederik Prijck <[email protected]>
* Migrate project to use Jest

* Remove karma and jasmine dependencies

* Exclude playground from coverage
* Add initial migration guide

* Add changes for openUrl

* Add logout return value

* Apply suggestions from code review
* Use openUrl instead of onRedirect

* update lock file

* fix ci

* update typedoc to show externals
* Bump version to 2.0.0

* Update changelog

* Ensure types are exported

* Update docs

* Bump version to 2.0.0-beta.0

* fix test

* Update CHANGELOG.md
* Bump version and updage changelog

* Generate docs for v2

* Remove beta references
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases)
- [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1)

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…cache-semantics-4.1.1

build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1
frederikprijck and others added 18 commits December 12, 2023 08:33
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…h0#554)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Frederik Prijck <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Frederik Prijck <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@PuriaRad
Copy link
Author

I only want to update the [email protected] to support higher Angular versions. Now, I cannot change the target branch to something rather than main. Please help me out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants