Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Carthage/Build to the frameworks search path #690

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Add Carthage/Build to the frameworks search path #690

merged 1 commit into from
Nov 29, 2021

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 20, 2021

Changes

This PR adds $(PROJECT_DIR)/Carthage/Build to the frameworks search path of the framework target.

References

Fixes #689

Testing

This change was tested manually.

Screen Shot 2021-11-20 at 00 16 24

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team as a code owner November 20, 2021 03:18
@Widcket Widcket merged commit eee48cc into master Nov 29, 2021
@Widcket Widcket deleted the fix/framework-search-path branch November 29, 2021 14:50
@Widcket Widcket mentioned this pull request Nov 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Fixed review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail to compile using carthage 0.38 and Xcode 13.1
2 participants
@Widcket @stevehobbsdev