Added support for terms and privacy button color customization #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejensen
commented
Feb 11, 2021
| @@ -249,7 +251,8 @@ class DatabasePresenter: Presentable, Loggable { | |||
| } | |||
| view.primaryButton?.onPress = checkTermsAndSignup | |||
| view.secondaryButton?.title = "By signing up, you agree to our terms of\n service and privacy policy".i18n(key: "com.auth0.lock.database.button.tos", comment: "tos & privacy") | |||
| view.secondaryButton?.color = UIColor(red: 0.9333, green: 0.9333, blue: 0.9333, alpha: 1.0) | |||
There was a problem hiding this comment.
This is where the button color was previously hardcoded
Widcket
approved these changes
Feb 11, 2021
Widcket
previously approved these changes
Feb 11, 2021
Widcket
approved these changes
Feb 11, 2021
|
Thanks @ejensen for this PR. |
Merged
|
This is now out in v2.22.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds the ability to customize the background color of the button for terms of service and privacy policy.
Previously the color was hardcoded to
UIColor(red: 0.9333, green: 0.9333, blue: 0.9333, alpha: 1.0)and could not be changed.Testing
Checklist