Fix bot detection CAPTCHA not being shown #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
previously approved these changes
Feb 8, 2021
|
Hi @ejensen, thanks for your PR. Can you please give access so I can push a commit to get the CI going? We're still experiencing issues, my apologies. |
Widcket
previously approved these changes
Feb 8, 2021
@ejensen can you please fix the tests? |
ejensen
force-pushed
the
fix-captcha-session-too-old
branch
from
edc6bfc
to
d722b1f
Compare
Tests have been updated |
Widcket
previously approved these changes
Feb 10, 2021
Widcket
approved these changes
Feb 10, 2021
Merged
|
This is now out in v2.22.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change makes the web session used during the bot detection CAPTCHA challenge ephemeral. This prevents issues where users are not able to complete the CAPTCHA challenge because the shared web session's credentials are too old, which makes the web session dismiss before the CAPTCHA is presented. Details and videos are in the linked support ticket and Lock.Android issue
References
Testing
Checklist