Fix LockViewController dismissal when presented as a popup #647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
On iPad, the
LockViewController
is presented as a.formSheet
. As such, it can be dismissed by simply tapping outside the bounds of the modal. In this scenario, there are two issues:closable
option has no effect on iPad #658: Theclosable
Lock option has no effect if set tofalse
(default): the modal will be dismissed either wayonCancel
callback not triggered when dismissing LockViewController on iPad #659: The developer gets no callbacks (onCancel
) after that dismissalChanges
isModalInPresentation
based onclosable
allows controlling whether or not UIKit should prevent the interactive dismissal of the modalpresentationControllerDidDismiss
allows us to trigger the cancel callback when the user manually dismissed the modalTesting
On iPad:
closable
option set to false (or not set, since that's the default), check that the lock modal does not get dismissed when tapping outside its bounds (used to fail before this change)closable
option set to true, check that the lock modal gets dismissed when tapping outside its bounds and that theonCancel
callback is triggered.Checklist