Added Swift Package Manager support [SDK-2118] #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cocojoe when you review it, can you please remove the old CI checks that were re-enabled by the automation script? The only CircleCI job that should remain is ci/circleci: build-and-test-swift-5_2. |
Widcket
commented
Nov 20, 2020
| @@ -55,11 +56,10 @@ class CountryTableViewControllerSpec: QuickSpec { | |||
|
|
|||
| it("should return cell info for Argentina") { | |||
| let index = IndexPath(item: 8, section: 0) | |||
| expect(tableView.cellForRow(at: index)?.textLabel?.text) == "Argentina" | |||
| expect(tableView.cellForRow(at: index)?.detailTextLabel?.text) == "+54" | |||
There was a problem hiding this comment.
Those are failing on master with Xcode 12.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for the Swift Package Manager (SPM). The
Package.swiftfile defines 2 targets:Lockfor the library code and a test target for the tests.No public APIs were added or modified.
References
Testing
The changes were tested manually as follows:
Those tests were executed with:
Checklist