Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Quick and Nimble #641

Merged
merged 5 commits into from
Oct 22, 2020
Merged

Updated Quick and Nimble #641

merged 5 commits into from
Oct 22, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Oct 20, 2020

Changes

This PR updates the test dependencies Quick and Nimble to the latest majors, making it possible to test Lock.swift with Xcode 12.

The new majors of Quick and Nimble no longer support Swift versions < 5.2. This means that the tests can no longer be run on Xcode versions < 11.4. The CircleCI config has been updated accordingly.

The requirements section in the README has been updated as well.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added this to the vNext milestone Oct 20, 2020
@Widcket Widcket requested a review from a team October 20, 2020 03:15
@Widcket Widcket added review:large Large review and removed review:small Small review labels Oct 20, 2020
return false
}
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was producing a warning, as CredentialAuthError already implements Equatable in the library code. See https://github.com/auth0/Lock.swift/blob/master/Lock/CredentialAuthError.swift#L74

@Widcket Widcket added review:medium Medium review and removed review:large Large review labels Oct 20, 2020
@Widcket
Copy link
Contributor Author

Widcket commented Oct 20, 2020

@cocojoe can you please update the branch protection settings? The only CircleCI job that should be marked as required is build-and-test-swift-5_2 as the others have been removed.

README.md Show resolved Hide resolved
@Widcket Widcket requested a review from cocojoe October 20, 2020 09:14
@Widcket Widcket merged commit 3f8b253 into master Oct 22, 2020
@Widcket Widcket deleted the chore/update-dependencies branch October 22, 2020 12:29
@Widcket Widcket mentioned this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants