Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3702] README redesign #651

Merged
merged 8 commits into from
Oct 26, 2022
Merged

[SDK-3702] README redesign #651

merged 8 commits into from
Oct 26, 2022

Conversation

poovamraj
Copy link
Contributor

Changes

  • Changed to new README design
  • Added code of conduct page

@poovamraj poovamraj requested a review from a team as a code owner October 19, 2022 12:40
@poovamraj poovamraj changed the title README redesign [SDK-3702] README redesign Oct 19, 2022
stevehobbsdev
stevehobbsdev previously requested changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a couple of things

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
frederikprijck
frederikprijck requested changes Oct 25, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@poovamraj @frederikprijck
Update README.md
c20bd95 
Co-authored-by: Frederik Prijck <[email protected]>
@poovamraj poovamraj requested review from stevehobbsdev and removed request for stevehobbsdev October 25, 2022 10:26
@ewanharris ewanharris dismissed stevehobbsdev’s stale review October 26, 2022 08:47

Dismissing old review to allow merge as Fred's is newer

@ewanharris ewanharris merged commit 7037190 into main Oct 26, 2022
@ewanharris ewanharris deleted the readme-redesign branch October 26, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

@stevehobbsdev stevehobbsdev Awaiting requested review from stevehobbsdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@poovamraj @stevehobbsdev @frederikprijck @ewanharris