Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract the user id from the 'sub' claim if present #77

Merged
merged 1 commit into from
Feb 24, 2017
Merged

Extract the user id from the 'sub' claim if present #77

merged 1 commit into from
Feb 24, 2017

Conversation

lbalmaceda
Copy link
Contributor

As the UsersAPIClient and AuthenticationAPIClient return a UserProfile object on getProfile or userInfo, we need to ensure the instance can handle both id scenarios. The userProfile.getId() will return:

  1. The id value if present.
  2. The 'sub' claim if present
  3. Null in any other case.

@hzalaz hzalaz modified the milestone: v1-Next Feb 20, 2017
@lbalmaceda lbalmaceda merged commit d3c7294 into master Feb 24, 2017
@lbalmaceda lbalmaceda deleted the id-from-profile branch February 24, 2017 15:15
@lbalmaceda lbalmaceda modified the milestones: 1-Next, 1.6.0 Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzalaz hzalaz hzalaz approved these changes

Assignees

@hzalaz hzalaz

Labels
CH: Changed
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lbalmaceda @hzalaz