Log a warning message when using non-OIDC endpoints in OIDC mode #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
changed the title
lbalmaceda
force-pushed
the
add-oidc-flag-warning
branch
from
77f454b
to
8e4cb14
Compare
hzalaz
suggested changes
Jan 31, 2017
| @@ -85,6 +88,12 @@ public AuthenticationException(Map<String, Object> values) { | |||
| } | |||
| } | |||
|
|
|||
| private void warnIfOIDCError() { | |||
| if ("invalid_request".equals(getCode()) && getDescription().startsWith("OIDC conformant clients cannot use")) { | |||
There was a problem hiding this comment.
Let's mot ever match description values of errors let's print the error and the recommendation if it's invalid_request
hzalaz
changed the title
hzalaz
approved these changes
Jan 31, 2017
lbalmaceda
force-pushed
the
add-oidc-flag-warning
branch
from
4b2347f
to
52543c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the account used to create the
AuthenticationAPIClienthas the OIDCConformant flag disabled and the client (dashboard) has the flag enabled, the requests to/oauth/roand/oauth/access_tokenwill fail withinvalid_request. This PR check's that error and logs a warning message so the user can properly setup the android client and authenticate.