Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): Update OkHttp to 4.12.0 #696

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

evansims
Copy link
Member

@evansims evansims commented Oct 25, 2023

Changes

This PR follows up on #687 and bumps the OkHttp dependency to 4.12, now that it's been released. It removes the temporary workaround for forcing okio 3.5 with 4.11, as this is now included in 4.12.

References

This also resolves CVE-2020-29582, a vulnerability in OkHttp 4.11.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@evansims evansims temporarily deployed to internal October 25, 2023 21:21 — with GitHub Actions Inactive
@evansims evansims temporarily deployed to internal October 25, 2023 21:21 — with GitHub Actions Inactive
@evansims evansims added the dependencies One or more dependencies are being bumped label Oct 25, 2023
@evansims evansims marked this pull request as ready for review October 25, 2023 21:33
@evansims evansims requested a review from a team as a code owner October 25, 2023 21:33
@evansims
Copy link
Member Author

evansims commented Oct 25, 2023

Please disregard the canceled CircleCI build indicating a check failure; this was a leftover webhook from our recent CI migration to GitHub. I have disabled it within the repository for future PRs.

@evansims evansims merged commit 873989c into main Oct 25, 2023
9 of 10 checks passed
@evansims evansims deleted the chore/dependencies/update-to-okhttp-4.12.0 branch October 25, 2023 22:05
@poovamraj poovamraj mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies One or more dependencies are being bumped
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants