Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add federated option to the Web Auth Logout [SDK-2165] #501

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

lbalmaceda
Copy link
Contributor

Changes

This is a valid parameter exposed by the Authentication API that was missing in this SDK. Support for this feature is up to the Universal Login page and the external identity providers.

References

Internally: SDK-2165

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

I tested this signing in with my Google account on the device. The Google logout site seems to ignore the return to URL and instead takes you to the account selection screen. It does show that the account has been logged out, though.

Lavender.Partridge.mp4

Checklist

@lbalmaceda lbalmaceda added this to the v2-Next milestone Jul 16, 2021
@lbalmaceda lbalmaceda requested a review from a team as a code owner July 16, 2021 07:58
@lbalmaceda lbalmaceda merged commit e3f82a5 into main Jul 16, 2021
@lbalmaceda lbalmaceda modified the milestones: v2-Next, 2.4.0 Jul 20, 2021
@poovamraj poovamraj deleted the feat-fed-logout branch July 18, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants