Catch IOExceptions from response body InputStream

[jeffdgr8]

Changes

Handle exception from resultAdapter.fromJson(reader) call.

References

Closes #483

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.

• This change adds unit test coverage

• This change adds integration test coverage

• This change has been tested on the latest version of the platform/language or why not

Checklist

• I have read the Auth0 general contribution guidelines

• I have read the Auth0 Code of Conduct

• All existing and new tests complete without errors (*that were completing successfully before, 16 failed before and after changes)

[Marcono1234]

Should the potential exceptions from these lines be wrapped as well?

Auth0.Android/auth0/src/main/java/com/auth0/android/request/internal/BaseRequest.kt

Line 106 in 5f20b76

errorAdapter.fromJsonResponse(response.statusCode, reader)

(For fromJsonResponse maybe it would be the responsibility of the implementors of that method instead to catch the exceptions, so this might be outside the scope of this pull request.)

Auth0.Android/auth0/src/main/java/com/auth0/android/request/internal/BaseRequest.kt

Line 110 in 5f20b76

reader.readText(),

[lbalmaceda]

Thanks for opening this. Looks good, left two change requests.

[jeffdgr8]

Should the potential exceptions from these lines be wrapped as well?

Auth0.Android/auth0/src/main/java/com/auth0/android/request/internal/BaseRequest.kt

Line 106 in 5f20b76

errorAdapter.fromJsonResponse(response.statusCode, reader)

(For fromJsonResponse maybe it would be the responsibility of the implementors of that method instead to catch the exceptions, so this might be outside the scope of this pull request.)

Auth0.Android/auth0/src/main/java/com/auth0/android/request/internal/BaseRequest.kt

Line 110 in 5f20b76

reader.readText(),

@lbalmaceda as @Marcono1234 points out, this same exception or an IOException could result if the response is not a 200 and a similar error occurs while reading the response stream. It might work best to wrap this entire code segment to catch all exceptions from these sources. Or additionally wrap the errorAdapter calls at the bottom with a similar try/catch.

[lbalmaceda]

@jeffdgr8 Please let me know whether you will be progressing this PR or if we should pick it up from our side - thanks.

[jeffdgr8]

@lbalmaceda yes, sorry, had a busy last week. I'll take a look at this this evening.

[jeffdgr8]

Should the potential exceptions from these lines be wrapped as well?

Auth0.Android/auth0/src/main/java/com/auth0/android/request/internal/BaseRequest.kt

Line 106 in 5f20b76

errorAdapter.fromJsonResponse(response.statusCode, reader)

(For fromJsonResponse maybe it would be the responsibility of the implementors of that method instead to catch the exceptions, so this might be outside the scope of this pull request.)

Auth0.Android/auth0/src/main/java/com/auth0/android/request/internal/BaseRequest.kt

Line 110 in 5f20b76

reader.readText(),

@lbalmaceda as @Marcono1234 points out, this same exception or an IOException could result if the response is not a 200 and a similar error occurs while reading the response stream. It might work best to wrap this entire code segment to catch all exceptions from these sources. Or additionally wrap the errorAdapter calls at the bottom with a similar try/catch.

Fixed 5c035ef

[lbalmaceda]

Thanks for this!