Make JsonRequired annotation internal #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjames
requested changes
Feb 4, 2021
Co-authored-by: Jim Anderson <[email protected]>
jimmyjames
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This annotation is supposed to be internal and was public since 2016. This PR moves it into the
request.internalpackage and also changes its visibility to internal / package-private.These changes will help to reduce the exposure of Gson as a third-party dependency, making it easier to migrate off of it at some point in the future, if desired.
I've tested this with the sample app we ship with this v2 branch. The way I tested it was making a call to /oauth/token to authenticate, then /userinfo to grab the subject, and then /api/v2/users to get the full user profile. The intent was to pull the "UserIdentities" that are annotated with this class.