Support multiple response_type values #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
force-pushed
the
resp-type-idtoken
branch
4 times, most recently
from
cef8bfd
to
780349d
Compare
lbalmaceda
force-pushed
the
resp-type-idtoken
branch
from
780349d
to
d008135
Compare
hzalaz
suggested changes
Nov 25, 2016
| this.state = UUID.randomUUID().toString(); | ||
| this.scope = null; | ||
| withResponseType(ResponseType.CODE); | ||
| withState(UUID.randomUUID().toString()); |
| } | ||
|
|
||
| /** | ||
| * Use a custom nonce in the requests |
There was a problem hiding this comment.
Specify a custom nonce value to avoid replay attacks. It will be sent in the auth request that will be returned back as a claim in the id_token
| */ | ||
| public Builder withResponseType(@ResponseType int type) { | ||
| StringBuilder sb = new StringBuilder(); | ||
| if ((type & ResponseType.CODE) != 0) { |
There was a problem hiding this comment.
I think it should be (type & ResponseType.CODE) == ResponseType.CODE
| try { | ||
| final JWT idToken = new JWT(token); | ||
| final Claim nonceClaim = idToken.getClaim(KEY_NONCE); | ||
| return !(nonceClaim == null || !nonce.equals(nonceClaim.asString())); |
There was a problem hiding this comment.
Can we avoid the double negation?
| queryParameters.put(KEY_RESPONSE_TYPE, RESPONSE_TYPE_TOKEN); | ||
|
|
||
| if (!getResponseType().contains(RESPONSE_TYPE_ID_TOKEN)) { | ||
| queryParameters.remove(KEY_NONCE); |
There was a problem hiding this comment.
We should only do this if we generated the nonce, if the user provided one we should still send it
lbalmaceda
force-pushed
the
resp-type-idtoken
branch
2 times, most recently
from
1997f3a
to
ad79347
Compare
lbalmaceda
force-pushed
the
resp-type-idtoken
branch
from
ad79347
to
c1bec1a
Compare
hzalaz
approved these changes
Nov 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAuthProvidercan now handle multiple response_type values as per https://openid.net/specs/oauth-v2-multiple-response-types-1_0.html#Combinations.Posible values are:
ResponseType.CODEResponseType.ID_TOKENResponseType.TOKENi.e.: