Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Move passwordless "invalid credentials" errors #373

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Conversation

lbalmaceda
Copy link
Contributor

Changes

On the last patch we released support for catching additional Passwordless error messages that were missing from this SDK. However, we realized that the method in which those were added was not quite right, as it corresponded to MFA flows. This PR changes that and moves the new error handling into a proper method for invalid credentials.

TLDR

If you were using version 1.29.1 to catch Passwordless invalid code errors, you will need to update your code:

-boolean invalidInput = err.isMultifactorCodeInvalid()
+boolean invalidInput = err.isInvalidCredentials()

References

This rollbacks the changes introduced in #371, but keeps them in a separate method.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda added CH: Fixed small Small review labels Nov 11, 2020
@lbalmaceda lbalmaceda added this to the v1-Next milestone Nov 11, 2020
@lbalmaceda lbalmaceda requested a review from a team as a code owner November 11, 2020 18:39
@lbalmaceda lbalmaceda merged commit 778348a into master Nov 11, 2020
@Widcket Widcket deleted the otp-mfa branch November 11, 2020 21:08
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.29.2 Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Fixed small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants