Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Filter allowed CustomTabs browsers #353

Merged
merged 9 commits into from
Sep 25, 2020
Merged

Feat: Filter allowed CustomTabs browsers #353

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
056038f
Adding support to override the browser packages to be used during Log…
nelsonmaia Sep 8, 2020
7236981
Adding support to search all the browsers in the device
nelsonmaia Sep 11, 2020
f3b3b64
refactor to use extensible BrowserPicker filtering
lbalmaceda Sep 22, 2020
57badc1
Fix tests for changed logic
lbalmaceda Sep 23, 2020
1df97f9
Replace deprecated import with the alternative
lbalmaceda Sep 23, 2020
2070eb9
add tests for the BrowserPicker class
lbalmaceda Sep 23, 2020
e1692ff
add coverage for introduced use cases and javadocs
lbalmaceda Sep 23, 2020
4c25864
add CompatibleBrowser tests
lbalmaceda Sep 23, 2020
7985131
fix flag passed when querying browser apps for post marshmallow
lbalmaceda Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding support to search all the browsers in the device
  • Loading branch information
@nelsonmaia @lbalmaceda
nelsonmaia authored and lbalmaceda committed Sep 22, 2020
commit 723698123c2c7622c34bb17501d0ac27077e1df2
14 changes: 12 additions & 2 deletions auth0/src/main/java/com/auth0/android/provider/CustomTabsController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,19 @@ static String getBestSupportedBrowserPackage(@NonNull Context context, @Nullable
PackageManager pm = context.getPackageManager();
Intent browserIntent = new Intent(Intent.ACTION_VIEW, Uri.parse("http:https://www.example.com"));

String[] browserPackages = overrideBrowserPackages == null ? getBrowserPackages(pm) : overrideBrowserPackages;
String[] browserPackages;
int packageManagerFlags;

// if the overrideBrowserPackages is null, preserve old behaviour of the library
if(overrideBrowserPackages != null){
browserPackages = overrideBrowserPackages;
packageManagerFlags = PackageManager.MATCH_ALL;
}else{
browserPackages = getBrowserPackages(pm);
packageManagerFlags = 0;
}

List<ResolveInfo> resolvedActivityList = pm.queryIntentActivities(browserIntent, 0);
List<ResolveInfo> resolvedActivityList = pm.queryIntentActivities(browserIntent, packageManagerFlags);
List<String> customTabsBrowsers = new ArrayList<>();
for (ResolveInfo info : resolvedActivityList) {
Intent serviceIntent = new Intent();
Expand Down