Use of a unique keystore key alias across apps #315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The intention is to use the App's Package Name from the
Context
vs the library's Application ID from theBuildConfig
, to generate a key alias that is unique across app installs. This should prevent errors where apps using this very same library (or sharing the key alias) would have their keys collide.Note
Since the key alias is changing with this PR, when you update to this last version of the SDK, any existing key will not be found and it will act as if the user was logged out. Double-check that you are not ignoring the exceptions thrown when the credential manager methods are being used. See our docs for more information.
References
Closes #309
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. Since this library has unit testing, tests should be added for new functionality and existing tests should complete without errors.
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors