Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve consistency around Expires At in CredentialsManager #295

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Improve consistency around Expires At in CredentialsManager #295

merged 2 commits into from
Mar 30, 2020

Conversation

lbalmaceda
Copy link
Contributor

@lbalmaceda lbalmaceda commented Mar 27, 2020 •
edited
Loading

Changes

Add a missing test case. Also, improve consistency on the usage of Expires At for the CredentialsManager class.

References

Will close #293

Testing

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda requested a review from a team March 27, 2020 20:13
@lbalmaceda lbalmaceda added this to the v1-Next milestone Mar 27, 2020
@lbalmaceda lbalmaceda added the small Small review label Mar 27, 2020
@lbalmaceda lbalmaceda merged commit dc19c45 into master Mar 30, 2020
@lbalmaceda lbalmaceda deleted the test-cred-man branch March 30, 2020 18:28
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.23.0 Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
CH: Fixed small Small review
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

SecureCredentialsManager's tokens expiration checks contains bug.
2 participants
@lbalmaceda @Widcket