Allow to customize the redirect URI / return to URL #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
commented
Jan 28, 2020
| @@ -43,7 +43,7 @@ | |||
| * | |||
| * @return the callback Uri. | |||
| */ | |||
| public static String getCallbackUri(@NonNull String scheme, @NonNull String packageName, @NonNull String domain) { | |||
There was a problem hiding this comment.
class is package private already 👍
Widcket
reviewed
Jan 28, 2020
auth0/src/main/java/com/auth0/android/provider/WebAuthProvider.java
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Jan 28, 2020
auth0/src/main/java/com/auth0/android/provider/WebAuthProvider.java
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Jan 28, 2020
auth0/src/main/java/com/auth0/android/provider/WebAuthProvider.java
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Jan 28, 2020
Widcket
reviewed
Jan 28, 2020
auth0/src/test/java/com/auth0/android/provider/WebAuthProviderTest.java
Outdated
Show resolved
Hide resolved
Widcket
requested changes
Jan 28, 2020
Widcket
reviewed
Jan 29, 2020
auth0/src/main/java/com/auth0/android/provider/WebAuthProvider.java
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Jan 29, 2020
auth0/src/main/java/com/auth0/android/provider/WebAuthProvider.java
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Jan 29, 2020
| @@ -255,6 +272,19 @@ public Builder withScheme(@NonNull String scheme) { | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * Specify a custom Redirect Uri to use to invoke the app on redirection. | |||
There was a problem hiding this comment.
Same as above. There are 2 instances in this doc comment.
Widcket
reviewed
Jan 29, 2020
| @@ -241,9 +258,9 @@ public Builder withAudience(@NonNull String audience) { | |||
| } | |||
|
|
|||
| /** | |||
| * Specify a custom Scheme to use on the Callback Uri. Default scheme is 'https'. | |||
| * Specify a custom Scheme to use on the Redirect Uri. Default scheme is 'https'. | |||
There was a problem hiding this comment.
Please use URI in the doc comments, for consistency.
Widcket
previously approved these changes
Jan 29, 2020
Widcket
reviewed
Jan 29, 2020
auth0/src/main/java/com/auth0/android/provider/WebAuthProvider.java
Outdated
Show resolved
Hide resolved
Widcket
requested changes
Jan 29, 2020
Co-Authored-By: Rita Zerrizuela <[email protected]>
Co-Authored-By: Rita Zerrizuela <[email protected]>
lbalmaceda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds methods to the
WebAuthProviderbuilders in order to customize the URL used when the backend succeeds authenticating/logging out and needs to redirect back to the app.References
A similar PR existed previously #268.
Testing
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language or why not
Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors