Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OIDC passwordless #271

Merged
merged 4 commits into from
Dec 23, 2019
Merged

Add OIDC passwordless #271

merged 4 commits into from
Dec 23, 2019

Conversation

lbalmaceda
Copy link
Contributor

Changes

Passwordless flow is now enabled with the Passwordless OTP grant type for OIDC conformant clients. To make use of it, you'll need to enable the OIDC Conformant flag on the Auth0 instance as explained in the readme

References

Nothing here yet

Testing

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda added this to the v1-Next milestone Dec 6, 2019
@lbalmaceda lbalmaceda added the small Small review label Dec 6, 2019
@lbalmaceda lbalmaceda marked this pull request as ready for review December 6, 2019 17:59
@lbalmaceda lbalmaceda requested a review from a team December 6, 2019 17:59
cocojoe
cocojoe reviewed Dec 12, 2019
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question.

auth0/src/main/java/com/auth0/android/authentication/AuthenticationAPIClient.java Show resolved Hide resolved
@jimmyjames jimmyjames self-requested a review December 12, 2019 17:02
jimmyjames
jimmyjames approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbalmaceda lbalmaceda merged commit d5064ab into master Dec 23, 2019
@lbalmaceda lbalmaceda deleted the passwordless-v2 branch December 23, 2019 16:53
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.20.0 Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyjames jimmyjames jimmyjames approved these changes

@cocojoe cocojoe cocojoe approved these changes

Assignees
No one assigned
Labels
CH: Added small Small review
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lbalmaceda @jimmyjames @cocojoe