Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CredentialsManager migration scenario #266

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Fix CredentialsManager migration scenario #266

merged 1 commit into from
Nov 28, 2019

Conversation

lbalmaceda
Copy link
Contributor

Changes

Fix a bug when a field was not set yet, caused after migrating from version 1.19.0 to a newer one.

References

Closes #261

Testing

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda added this to the v1-Next milestone Nov 28, 2019
@lbalmaceda lbalmaceda requested a review from a team November 28, 2019 19:48
@lbalmaceda lbalmaceda added the small Small review label Nov 28, 2019
@lbalmaceda lbalmaceda merged commit 7f2b63e into master Nov 28, 2019
@lbalmaceda lbalmaceda deleted the fix-cred-man branch November 28, 2019 21:01
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.19.1 Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
CH: Fixed small Small review
Projects
None yet
Milestone
1.19.1
Development

Successfully merging this pull request may close these issues.

NPE in com.auth0.android.authentication.storage.CredentialsManager
2 participants
@lbalmaceda @damieng