Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some WebAuthProvider tests #248

Merged
merged 3 commits into from
Jun 28, 2019
Merged

Rename some WebAuthProvider tests #248

merged 3 commits into from
Jun 28, 2019

Conversation

lbalmaceda
Copy link
Contributor

Changes

Just a minor refactor. Since Logout and Login are now under the same WebAuthProvider class, I've renamed the previous authentication tests with a prefix/suffix indicating "Login".

I also fixed a javadoc warning where the text was missing the code syntax wrapper.

@lbalmaceda lbalmaceda added the small Small review label Jun 27, 2019
@lbalmaceda lbalmaceda requested a review from a team June 27, 2019 18:34
@lbalmaceda lbalmaceda force-pushed the fixup-javadoc branch 2 times, most recently from 1d1acb2 to a5814fa Compare June 27, 2019 18:41
@lbalmaceda lbalmaceda merged commit 0a58cca into master Jun 28, 2019
@lbalmaceda lbalmaceda deleted the fixup-javadoc branch December 3, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants