Disable HTTP 2 protocol on OkHttp client #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
commented
Mar 19, 2018
| @@ -37,25 +35,34 @@ | |||
| @Config(constants = com.auth0.android.auth0.BuildConfig.class, sdk = 21, manifest = Config.NONE) | |||
| public class OkHttpClientFactoryTest { | |||
|
|
|||
| private Activity activity; | |||
|
We should update to new Major OKHTTP one day. |
|
Yes. The next SDK will definitely run over OkHttp 3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OkHttp 2.7.5 (latest) doesn't seem to handle very well the
HTTP 2protocol. While this is fixed on the new OkHttp 3 that implies a breaking change we can't deal with right now.The present fix is removing the
HTTP 2protocol from the client allowed protocols list. Since the default protocols include bothHTTP 1.1andSPDY 3, those remain enabled.This will fix auth0/Lock.Android#457