Make CCT stay alive when activity is paused #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
force-pushed
the
fix-cct-resume-issue
branch
from
e3ae118
to
d8ef245
Compare
lbalmaceda
force-pushed
the
fix-cct-resume-issue
branch
from
d8ef245
to
9dcd91a
Compare
cocojoe
approved these changes
Oct 5, 2017
| @@ -126,7 +126,6 @@ public void run() { | |||
| final Intent intent = new CustomTabsIntent.Builder(session.get()) | |||
| .build() | |||
| .intent; | |||
| intent.addFlags(Intent.FLAG_ACTIVITY_NO_HISTORY); | |||
There was a problem hiding this comment.
Removing does not cause any other issues? Only asking as issues that required this to fix in RNA.
There was a problem hiding this comment.
CCT is not another tab that stays open on the browser, is more like an activity. By removing the flag you make the activity stay up after the app is paused/resumed. Yes, we should probably do the same for RNA and just keep that flag for browser (not CCT) authentication. I didn't do the PR yet because it's not just removing the flag.. CustomTabsIntent may fail to find a package that could "handle CCT and so default to use Browser. We must catch and add the flag to that case too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the flag, the CCT is not closed when the activity is paused and resumed. This is already working for Browser (not CCT mode) and Webview authentication. It might fix #116.