Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ansible-core 2.11 #32

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Add support for ansible-core 2.11 #32

merged 1 commit into from
Aug 4, 2021

Conversation

msafadieh
Copy link
Contributor

The ssh connector plugins added the new following variables: sshpass_prompt, ssh_transfer_method, and timeout. This causes the sshjail plugin to fail with the following error.

An exception occurred during task execution. To see the full traceback, use -vvv. The error was: KeyError: 'Requested entry (plugin_type: connection plugin: sshjail setting: ssh_transfer_me
thod ) was not defined in configuration.'                                                                                                                                                    
nginx.shams | FAILED! => {                                                                                                                                                                   
    "msg": "Unexpected failure during module execution.",                                                                                                                                    
    "stdout": ""                                                                                                                                                                             
} 

This PR fixes the bug by adding the new variables to sshjail's DOCUMENTATION string.

@Follpvosten
Copy link

I'd be very interested in getting this merged. This issue is stopping me from using the connection plugin.

@austinhyde
Copy link
Owner

Thanks a ton for the patch! Sorry it took so long to get it reviewed and merged. I did hit one snag, which is that apparently retries got renamed to connection_retries at some point and core 2.11 insists on it being present...

After doing some testing, it looks like updating that dict entry works all the way back to ansible 2.10, so I'll call that a success.

I'll merge this, then apply that rename real fast.

@austinhyde austinhyde merged commit 57aac35 into austinhyde:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants