Fix compilation error caused by youki #483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologize for breaking the build. Historically, we did not have a good consumer for the
libcontainer
exceptyouki
cli. This lead us to not focus on the other usecases for thelibcontainer
. The error previously observed is fixed on theyouki
side.I updated the commit to latest fix for
youki
and the build passes. I believeyouki
is releasing a new proper version0.1.0
soon, so we can switch to that version after the release is made. In this way, we don't have to track specific commits.For the
oci-spec
issue, I believe a good approach is foryouki
to re-export theoci-spec-rs
that it uses, so there is no version mis-match.