Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error caused by youki #483

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

yihuaf
Copy link
Contributor

@yihuaf yihuaf commented Jun 19, 2023

Apologize for breaking the build. Historically, we did not have a good consumer for the libcontainer except youki cli. This lead us to not focus on the other usecases for the libcontainer. The error previously observed is fixed on the youki side.

I updated the commit to latest fix for youki and the build passes. I believe youki is releasing a new proper version 0.1.0 soon, so we can switch to that version after the release is made. In this way, we don't have to track specific commits.

For the oci-spec issue, I believe a good approach is for youki to re-export the oci-spec-rs that it uses, so there is no version mis-match.

@cla-bot
Copy link

cla-bot bot commented Jun 19, 2023

In order to contribute to a Nivenly Foundation project you must sign and agree to the CLA. Reply with @cla-bot check to check again.

@yihuaf
Copy link
Contributor Author

yihuaf commented Jun 19, 2023

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Jun 19, 2023

The cla-bot has been summoned, and re-checked this pull request!

@yihuaf
Copy link
Contributor Author

yihuaf commented Jun 19, 2023

@dmah42 The failure seems to be from cargo +nightly udeps --package auraescript. Here is the specific failure:

error[E0080]: evaluation of constant value failed
    --> /home/eng/.cargo/registry/src/github.com-1ecc6299db9ec823/v8-0.66.0/src/isolate.rs:1715:3
     |
1715 |   assert!(size_of::<TypeId>() == size_of::<u64>());
     |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the evaluated program panicked at 'assertion failed: size_of::<TypeId>() == size_of::<u64>()', /home/eng/.cargo/registry/src/github.com-1ecc6299db9ec823/v8-0.66.0/src/isolate.rs:1715:3
     |
     = note: this error originates in the macro `assert` (in Nightly builds, run with -Z macro-backtrace for more info)

    Checking base64ct v1.5.3
For more information about this error, try `rustc --explain E0080`.
error: could not compile `v8` due to previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `v8` due to previous error
make: *** [Makefile:459: check-deps] Error 101
[eng@stardust aurae]$ 

Looks like v8 fails? I don't think it is related to this PR at all.

@yihuaf
Copy link
Contributor Author

yihuaf commented Jun 19, 2023

It seems rusty_v8 needs updated due to this change: denoland/rusty_v8#1249 and also this issue: denoland/rusty_v8#1248

@yihuaf yihuaf marked this pull request as ready for review June 19, 2023 22:10
@dmah42
Copy link
Contributor

dmah42 commented Jun 20, 2023

It seems rusty_v8 needs updated due to this change: denoland/rusty_v8#1249 and also this issue: denoland/rusty_v8#1248

as far as i can tell, v8 is coming in through serde_v8, which is coming in through deno_core and deno_runtime, which are pulled in by auraescript directly. we're quite a few minor versions behind on those so a bump seems reasonable.

bumping them brings in a new error though:

error: failed to select a version for `swc_ecma_codegen_macros`.
    ... required by package `deno_ast v0.27.0`
    ... which satisfies dependency `deno_ast = "^0.27.0"` of package `deno_runtime v0.117.0`
    ... which satisfies dependency `deno_runtime = "^0.117.0"` of package `auraescript v0.0.0 (/home/dma/dev/aurae-runtime/aurae/auraescript)`
versions that meet the requirements `=0.7.2` are: 0.7.2

all possible versions conflict with previously selected packages.

  previously selected package `swc_ecma_codegen_macros v0.7.1`
    ... which satisfies dependency `swc_ecma_codegen_macros = "=0.7.1"` of package `deno_ast v0.25.0`
    ... which satisfies dependency `deno_ast = "^0.25.0"` of package `auraescript v0.0.0 (/home/dma/dev/aurae-runtime/aurae/auraescript)`

failed to select a version for `swc_ecma_codegen_macros` which could resolve this conflict

so i think we need to merge this PR to get past the compile error, and then work on the deno bumps.

it's possible just bumping all of deno_{runtime,core,ast} should be enough but i'm not sure we want to mix them into one PR.

@dmah42 dmah42 merged commit 788711e into aurae-runtime:main Jun 20, 2023
9 of 11 checks passed
@yihuaf yihuaf deleted the yihuaf/fix-youki branch June 20, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants