Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request template #4

Merged
merged 5 commits into from
May 22, 2023
Merged

Pull request template #4

merged 5 commits into from
May 22, 2023

Conversation

lebe1
Copy link
Collaborator

@lebe1 lebe1 commented May 15, 2023

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Description

Fixes

Features

  • Added template for pull requests in github

Documentation change

Concerns

New dependency

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code (or ChatGPT did), particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings, neither in my IDE nor in my browser
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes are dependent to changes to another repo, which is mentioned
  • Any dependent changes of other open branches are mentioned and linked together

app/main.go Outdated Show resolved Hide resolved
@nanu-c nanu-c self-requested a review May 22, 2023 10:17
@nanu-c nanu-c merged commit dcf3a56 into main May 22, 2023
@jofmi jofmi deleted the Pull-Request-template branch June 19, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants