Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework atuin init #652

Merged
merged 3 commits into from
Dec 24, 2022
Merged

Rework atuin init #652

merged 3 commits into from
Dec 24, 2022

Conversation

Sciencentistguy
Copy link
Contributor

This allows users to disable the CTRL-R and Up Arrow bindings, independently from one another.

The default is to bind both, but by adding --disable-ctrl-r or --disable-up-arrow (or both!) to the invocation of atuin init <shell> in the shell rc file, each can be disabled.

This allows users to disable the CTRL-R and Up Arrow bindings,
independently from one another
Copy link
Collaborator

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea. I think it makes sense and I don't see a reason this would be breaking

@ellie
Copy link
Member

ellie commented Dec 22, 2022

I like this, thank you!

Totally happy to merge this as-is, although if you could also update our documentation that would be great

Perhaps highlighting the disabling of up in the main README file too would be good, lots of people ask about this

docs/key-binding.md Outdated Show resolved Hide resolved
docs/key-binding.md Outdated Show resolved Hide resolved
@ellie ellie enabled auto-merge (squash) December 24, 2022 17:17
@ellie ellie merged commit a5616ae into atuinsh:main Dec 24, 2022
@ellie
Copy link
Member

ellie commented Dec 24, 2022

Thank you for this! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants