Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --locked flag for CI builds #337

Merged
merged 2 commits into from
Apr 23, 2022
Merged

Use --locked flag for CI builds #337

merged 2 commits into from
Apr 23, 2022

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Apr 23, 2022

This PR adds --locked flag to cargo build commands in CI/CD workflows. This is beneficial for spotting the outdated lockfile issues mentioned in #336

@ellie ellie enabled auto-merge (squash) April 23, 2022 20:20
@orhun
Copy link
Contributor Author

orhun commented Apr 23, 2022

I'm going to merge this with that job failing - it's failing due to the lockfile needing updating, which was done in #336

I merged main into this branch 2 seconds ago 😄 It should be fine now.

@ellie ellie merged commit a050faa into atuinsh:main Apr 23, 2022
ellie added a commit that referenced this pull request Apr 23, 2022
@ellie
Release v0.9.1
9c8f66c 
a050faa Use `--locked` flag for CI builds (#337)
8737474 Update Cargo.lock (#336)
eab1dbf sql builder (#333)

Fixed to include an updated lockfile that was missed in the last release

Thank you for the rapid report @orhun!
@ellie ellie mentioned this pull request Apr 23, 2022
Merged
ellie added a commit that referenced this pull request Apr 23, 2022
@ellie
Release v0.9.1 (#338)
2fd9651 
a050faa Use `--locked` flag for CI builds (#337)
8737474 Update Cargo.lock (#336)
eab1dbf sql builder (#333)

Fixed to include an updated lockfile that was missed in the last release

Thank you for the rapid report @orhun!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellie ellie ellie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhun @ellie