-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With just a few lines of code pub async fn run(self) -> Result<()> {
+ let tracer = opentelemetry_jaeger::new_pipeline().install_simple()?;
+
tracing_subscriber::registry()
.with(fmt::layer())
.with(EnvFilter::from_default_env())
+ .with(tracing_opentelemetry::layer().with_tracer(tracer))
.init(); we can get nice traces like this :) |
61ed875
to
7ec6867
Compare
conradludgate
commented
Apr 21, 2022
@@ -77,20 +78,23 @@ impl Postgres { | |||
|
|||
#[async_trait] | |||
impl Database for Postgres { | |||
#[instrument(skip_all)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reasoning for skip_all
is that it's usually better form to opt_in which fields you want to log (for PII as well as just for noisy structs like db handles).
In tracing 0.2, this will be the default: tokio-rs/tracing#651
ellie
approved these changes
Apr 21, 2022
ellie
added a commit
that referenced
this pull request
Apr 23, 2022
89549b3 Bump uuid from 0.8.2 to 1.0.0 (#311) 831cc98 Fix typos in the docs. (#171) 7436e4f feature-flags (#328) 508d4f4 History filter (#329) 02c70de refactor (#327) a9d1ece Added docker-compose.yml (#325) b8bdd83 Bump clap from 3.1.10 to 3.1.11 (#323) 52a3d0c Bump tracing from 0.1.33 to 0.1.34 (#324) 79597b0 Bump clap_complete from 3.1.1 to 3.1.2 (#316) 5aca611 Allow for larger commands (#321) 9085485 tracing (#315) 98d70fb treat popos as ubuntu (#319) d57f549 refactor commands for better separation (#313) 24e2971 Fix SQL cache query (#318) fe05d86 Fix delete trigger (#317) 48747e3 A few minor tweaks (#314) ed4e07d Use the count cache (#312) 6e11b8e Bump clap from 3.1.9 to 3.1.10 (#309) 44e417d Bump axum from 0.5.1 to 0.5.3 (#310) b98a378 Add count trigger (#308) 7fe523a Bump sqlx from 0.5.11 to 0.5.13 (#305) c5ab2a4 Bump clap from 3.1.8 to 3.1.9 (#306) 55f66c8 Bump cli-table from 0.4.6 to 0.4.7 (#297) 69279d2 Bump config from 0.13.0 to 0.13.1 (#303) d94cdae README: add MacPorts installation instructions (#302) f4240aa Initial implementation of calendar API (#298) 3c5fbc5 provide better error messages (#300) bc45bab remove default db uri (#299) 4897f4a Bump rmp-serde from 0.15.5 to 1.0.0 (#264) 5b2e828 Bump directories from 3.0.2 to 4.0.1 (#246) 016386c Bump urlencoding from 1.3.3 to 2.1.0 (#208) a95018c goodbye warp, hello axum (#296) 3b7ed7c fix env config parsing (#295)
Merged
ellie
added a commit
that referenced
this pull request
Apr 23, 2022
89549b3 Bump uuid from 0.8.2 to 1.0.0 (#311) 831cc98 Fix typos in the docs. (#171) 7436e4f feature-flags (#328) 508d4f4 History filter (#329) 02c70de refactor (#327) a9d1ece Added docker-compose.yml (#325) b8bdd83 Bump clap from 3.1.10 to 3.1.11 (#323) 52a3d0c Bump tracing from 0.1.33 to 0.1.34 (#324) 79597b0 Bump clap_complete from 3.1.1 to 3.1.2 (#316) 5aca611 Allow for larger commands (#321) 9085485 tracing (#315) 98d70fb treat popos as ubuntu (#319) d57f549 refactor commands for better separation (#313) 24e2971 Fix SQL cache query (#318) fe05d86 Fix delete trigger (#317) 48747e3 A few minor tweaks (#314) ed4e07d Use the count cache (#312) 6e11b8e Bump clap from 3.1.9 to 3.1.10 (#309) 44e417d Bump axum from 0.5.1 to 0.5.3 (#310) b98a378 Add count trigger (#308) 7fe523a Bump sqlx from 0.5.11 to 0.5.13 (#305) c5ab2a4 Bump clap from 3.1.8 to 3.1.9 (#306) 55f66c8 Bump cli-table from 0.4.6 to 0.4.7 (#297) 69279d2 Bump config from 0.13.0 to 0.13.1 (#303) d94cdae README: add MacPorts installation instructions (#302) f4240aa Initial implementation of calendar API (#298) 3c5fbc5 provide better error messages (#300) bc45bab remove default db uri (#299) 4897f4a Bump rmp-serde from 0.15.5 to 1.0.0 (#264) 5b2e828 Bump directories from 3.0.2 to 4.0.1 (#246) 016386c Bump urlencoding from 1.3.3 to 2.1.0 (#208) a95018c goodbye warp, hello axum (#296) 3b7ed7c fix env config parsing (#295)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tracing support and some simple instrumentations :)
For now, this doesn't log much new. example log line:
Before:
After:
The more info you add to the spans (and the more spans you have), the more you'll see in these events.