Fix history list --cwd errors

[lmburns]

Before the fix

$ atuin history list --cwd

Error: error returned from database: near "/": syntax error

Caused by:
    near "/": syntax error

Location:
    atuin-client/src/database.rs:316:19

1. The query into the database was not quoting the path. This fixes that issue.
2. Unused dependencies are removed:

atuin
    - fork

atuin-client
    - fern
    - humantime
    - indicatif

atuin-common
    - eyre
    - rmp-serde

atuin-sever
    - chrono-english
    - directories
    - fern
    - fork
    - indicatif
    - parse_duration
    - rmp-serde
    - unicode-width
    - urlencoding

3. I fixed the zsh plugin by standardizing it according to zdharma. The reference can be found in the file. It results in the following:

0="${${ZERO:-${0:#$ZSH_ARGZERO}}:-${(%):-%N}}"
0="${${(M)0:#/*}:-$PWD/$0}"

The $commands array is also loaded with zmodload in case the user doesn't have it loaded for whatever reason

[conradludgate]

Do you mind splitting out the zsh plugin change into a separate PR? I'm gonna need some extra time to digest that.

[conradludgate]

Hmm. Looking at the history queries, we really should move to using compile-time checked queries (or at least ones with proper parameter support).

I'll tentatively accept this for now though (once clippy is happy and when the zsh changes are moved out)

[lmburns]

I'll take them out. Here is some documentation for you to checkout. The only use for it is to make sure that the correct file is sourced and that the $commands array is correctly loaded. It is loaded by default, but some people may not have it for whatever reason

Documentation

zmodload
ZSH_ARGZERO
%N
Parameter expansion: ${(%):-...}
zsh/parameter module
zinit repo
zsh plugin standard
GitHub search showing several other examples using this

The complexity of the command is explained in the link mentioned above saying "plugin standard".

[lmburns]

Clippy lints should be fixed now. I don't know why they weren't already done because they were all in files that I did not modify. It must've been merged last time before completing the clippy lints.

This should be able to be merged now.

[conradludgate]

Thanks for this, just the formatting to go 😅.

cargo fmt --all

Should do the trick so you don't need to do it manually

[lmburns]

Maybe a github-workflow could be used to prevent this from happening?

Something similar to this or this. Or pre-commit could be used, but that would require everyone having this program.

It would prevent a commit from every happening without passing these checks.

[conradludgate]

Seems there's still formatting issues, do you have some custom formatting rules set up globally?

[lmburns]

I don't have a rustfmt.toml in the directory, but I'm guessing that it may have read it from my home directory

[conradludgate]

@ellie, thoughts?

[ellie]

LGTM! Thanks for the work here 💖