Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of algorithm code before project submission #20

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Conversation

jporemba
Copy link
Collaborator

Nothing major to look at it

Copy link
Collaborator

@DSep DSep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

override def sum(a: Int, b: Int): Int = Math.max(a, b)

// Compute new local state for this vertex based on accumulated sum
override def apply(superStepNumber: Int, thisVertex: VertexInfo, oldVal: Colour, total: Option[Int]): Colour = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, if you want to keep longer line lengths then maybe also change the .scalafmt.conf to match your desired limit

@jporemba jporemba merged commit 3c4f245 into main Dec 21, 2021
@jporemba jporemba deleted the alg-cleanup branch December 21, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants