Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: voting vertices now send null messages to their neighbours #13

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

jporemba
Copy link
Collaborator

The bug was that upon voting to terminate, a vertex was not sending (null) messages to its out-neighbours.
If those out-neighbours were waiting on in-neighbour messages, they wouldn't continue, hence failing to terminate.

Copy link
Collaborator

@DSep DSep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(Sorry I didn't notice that!)

@jporemba jporemba merged commit 9a01498 into main Nov 17, 2021
@jporemba jporemba deleted the termination-bug branch November 17, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants