This repository has been archived by the owner on Dec 19, 2017. It is now read-only.
ServerSessionManager: only try to remove consistent information #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that a client creates 2 sessions if the first attempt times out. In this case the ServerSessionManager will associate the 2nd session to the client but the 1st session that is left unatended will time out and eventually be unregistered. When this is done it will cause the maps in this object to have the client/session entry removed but those are already pointing to the new information that is in use. Their removal will cause issues in cluster operation. Fixes atomix#257
|
This is great! I was actually just looking at this yesterday and realized the client ID should probably also be used to unregister clients' sessions when a new session for the client is registered as well to ensure old sessions don't hang around for too long, but that should be done in another issue. |
kuujo
approved these changes
Jan 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that a client creates 2 sessions if the first attempt
times out. In this case the ServerSessionManager will associate the 2nd
session to the client but the 1st session that is left unatended will
time out and eventually be unregistered.
When this is done it will cause the maps in this object to have the
client/session entry removed but those are already pointing to the new
information that is in use. Their removal will cause issues in cluster
operation.
Fixes #257