Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Prefer prefix ++/-- operators for non-primitive types #1

Merged
merged 1 commit into from
Jul 27, 2013
Merged

Prefer prefix ++/-- operators for non-primitive types #1

merged 1 commit into from
Jul 27, 2013

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Jul 27, 2013

Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.

Issue(s) found via cppcheck.

@kevinsawicki
Copy link
Contributor

The build failure is unrelated to your change, but if you rebase on the latest master and repush this PR it should build successfully now on Travis CI.

Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
@mscdex
Copy link
Contributor Author

mscdex commented Jul 27, 2013

Done.

@kevinsawicki kevinsawicki merged commit 185db2f into atom:master Jul 27, 2013
@kevinsawicki
Copy link
Contributor

Cool, thanks for contributing this, merged into master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants