Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MSTeams CodeBlock element #293

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Add MSTeams CodeBlock element #293

merged 1 commit into from
Aug 23, 2024

Conversation

MichaelUrman
Copy link

This adds support for the extension element CodeBlock.

@MichaelUrman MichaelUrman mentioned this pull request Aug 8, 2024
Closed
@atc0005 atc0005 self-requested a review August 8, 2024 22:10
@atc0005 atc0005 added this to the v2.13.0 milestone Aug 8, 2024
@atc0005 atc0005 self-assigned this Aug 8, 2024
@atc0005 atc0005 added enhancement New feature or request card format/adaptivecard Adaptive Card support validation labels Aug 8, 2024
@atc0005
Copy link
Owner

atc0005 commented Aug 23, 2024

@MichaelUrman

Thanks again for submitting this PR and the discussion on GH-288.

I'll rebase this branch and then merge it.

As noted on GH-288 I'll submit a follow-up PR for the other items.

@atc0005
Copy link
Owner

atc0005 commented Aug 23, 2024 •
edited
Loading

CI failures:

  • typo (will fix later)
  • linting warning regarding a feature added in Go 1.16, deprecated in Go 1.19
    • this project's go.mod file specifies Go 1.14 (it doesn't currently use any features from a newer Go version), so this linting warning should not be surfaced
    • considering this an issue with the CI configuration instead of this project

EDIT:

Submitted upstream bug report for item 2:

@atc0005 atc0005 merged commit c0d6d3e into atc0005:master Aug 23, 2024
28 of 31 checks passed
@atc0005 atc0005 linked an issue Aug 23, 2024 that may be closed by this pull request
How to add elements: RichTextBlock, CodeBlock? #288
Closed
@atc0005 atc0005 mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atc0005 atc0005 Awaiting requested review from atc0005

Assignees

@atc0005 atc0005

Labels
card format/adaptivecard Adaptive Card support enhancement New feature or request validation
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.

How to add elements: RichTextBlock, CodeBlock?
2 participants
@MichaelUrman @atc0005