Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InList, InListIfFieldValNotEmpty validators #212

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

atc0005
Copy link
Owner

@atc0005 atc0005 commented Mar 23, 2023

Update handling of valid values list to explicitly consider an empty list to compare against as false.

This was already the case based on the use of a helper function's logic (goteamsnotify.InList), but this was not handled/noted explicitly.

Update handling of valid values list to explicitly consider
an empty list to compare against as false.

This was already the case based on the use of a helper function's
logic (goteamsnotify.InList), but this was not handled/noted
explicitly.
@atc0005 atc0005 added documentation Improvements or additions to documentation validation labels Mar 23, 2023
@atc0005 atc0005 added this to the v2.7.1 milestone Mar 23, 2023
@atc0005 atc0005 self-assigned this Mar 23, 2023
@atc0005 atc0005 merged commit ee5112d into master Mar 23, 2023
@atc0005 atc0005 deleted the update-validator-in-list-logic-to-be-explicit branch March 23, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant