Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breakpoint doesn't work with sass 1.49.9 because of breaking change: slash as division #188

Closed
aykut-rocks opened this issue Mar 14, 2022 · 5 comments

Comments

@aykut-rocks
Copy link

aykut-rocks commented Mar 14, 2022

see: https://sass-lang.com/d/slash-div

@aykut-rocks aykut-rocks changed the title breakpoint doesn't work properly with sass 1.49.9 because of breaking change: slash as division breakpoint doesn't work with sass 1.49.9 because of breaking change: slash as division Mar 14, 2022
@wats958
Copy link

wats958 commented Mar 30, 2022

More specifically, it throws a deprecation warning... it works for now, but not sure how much longer.

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($value, 16px) or calc($value / 16px)
More info and automated migrator: https://sass-lang.com/d/slash-div

    node_modules/breakpoint-sass/stylesheets/breakpoint/_helpers.scss 28:13                base-conversion()
    node_modules/breakpoint-sass/stylesheets/breakpoint/_helpers.scss 20:13                breakpoint-to-base-em()
    node_modules/breakpoint-sass/stylesheets/breakpoint/parsers/single/_default.scss 8:29  breakpoint-parse-default()
    node_modules/breakpoint-sass/stylesheets/breakpoint/parsers/_single.scss 22:14         breakpoint-parse-single()
    node_modules/breakpoint-sass/stylesheets/breakpoint/_parsers.scss 153:18               breakpoint-parse()
    node_modules/breakpoint-sass/stylesheets/breakpoint/_parsers.scss 48:22                breakpoint()
    node_modules/breakpoint-sass/stylesheets/_breakpoint.scss 46:16                        breakpoint()

@aykut-rocks
Copy link
Author

Is breakpoint still maintained at all? the last version was from 2016. we urgently need a new version with dart sass support for our project. what else could be the alternative? is there a comparable sass mixin?

@Snugug
Copy link
Member

Snugug commented Apr 21, 2022 via email

@sprioleau
Copy link
Contributor

sprioleau commented Jul 29, 2022

@Snugug I've created a pull request to address this issue.
#190

@Snugug
Copy link
Member

Snugug commented Jul 29, 2022

Thanks. Work's been hectic. I'll look at your PR this weekend

@Snugug Snugug closed this as completed in dde9670 Aug 14, 2022
Snugug added a commit that referenced this issue Aug 14, 2022
Fixes Sass division deprecation warning
Resolves #188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants