Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoint without Compass #108

Closed
rctneil opened this issue Jul 27, 2014 · 24 comments · Fixed by #110
Closed

Breakpoint without Compass #108

rctneil opened this issue Jul 27, 2014 · 24 comments · Fixed by #110

Comments

@rctneil
Copy link
Contributor

rctneil commented Jul 27, 2014

Anychance that someone could help with this issue here: http:https://stackoverflow.com/questions/24963153/breakpoint-in-rails-app about getting Breakpoint to work without Compass?

Thanks,
Neil

@rctneil
Copy link
Contributor Author

rctneil commented Jul 27, 2014

This has been solved by using Bower but I feel like something could maybe be added to Breakpoint to check for Compass and if Compass is not found then to add Breakpoint automatically to the Sass path so it works in the same way as Susy 2 does.

@rctneil rctneil closed this as completed Jul 27, 2014
@lolmaus
Copy link
Contributor

lolmaus commented Jul 28, 2014

@rctneil, what do you mean?

Compass is the instrument to make the Breakpoint extension available in your Sass code. How can Breakpoint check for Compass availability before it is itself availalbe?

@Snugug
Copy link
Member

Snugug commented Jul 28, 2014

We have this code in another extension. I've been meaning to update all of the major extensions with it but haven't yet.

On Jul 28, 2014, at 6:48 AM, lolmaus [email protected] wrote:

@rctneil, what do you mean?

Compass is the instrument to make the Breakpoint extension available in your Sass code. How can Breakpoint check for Compass availability before it is itself availalbe?


Reply to this email directly or view it on GitHub.

@rctneil
Copy link
Contributor Author

rctneil commented Jul 28, 2014

Nice. I look forward to it being integrated. Thanks for understanding what I meant.

@lolmaus
Copy link
Contributor

lolmaus commented Jul 28, 2014

But what did you mean? What "code from another extension" is @Snugug talking about?

Snugug added a commit that referenced this issue Jul 28, 2014
@Snugug
Copy link
Member

Snugug commented Jul 28, 2014

Singularity and Toolkit have also been updated, following the lead of Sassy Maps.

@rctneil
Copy link
Contributor Author

rctneil commented Jul 28, 2014

Fantastic. Thankyou, I will give this a shot later.

@lolmaus
Copy link
Contributor

lolmaus commented Jul 28, 2014

@Snugug, i assume you're talking about this code: at-import/Singularity@1a64c4e

Does it allow importing a Sass library by its pathless name, e. g. @import 'singularity'? What are the requirements for that to work? Bundler?

@rctneil
Copy link
Contributor Author

rctneil commented Jul 28, 2014

@Snugug I've just added Breakpoint 2.4.5 to my gem file and it still states "File to import not found or unreadable: breakpoint." Any ideas?

@rctneil rctneil reopened this Jul 28, 2014
@Snugug
Copy link
Member

Snugug commented Jul 28, 2014

Hmm, no, no idea. That code was borrowed from someone who knows Ruby and works in a Ruby enviro, which I don't. I'll look a little deeper, but not sure why it's not working.

@rctneil
Copy link
Contributor Author

rctneil commented Jul 28, 2014

@Snugug To aid debugging, here's the error:

File to import not found or unreadable: breakpoint.
Load paths:
/Volumes/Storage1/Code/site.co.uk/app/assets/fonts
/Volumes/Storage1/Code/site.co.uk/app/assets/images
/Volumes/Storage1/Code/site.co.uk/app/assets/javascripts
/Volumes/Storage1/Code/site.co.uk/app/assets/stylesheets
/Volumes/Storage1/Code/site.co.uk/app/assets/svgs
/Volumes/Storage1/Code/site.co.uk/vendor/assets/components
/Volumes/Storage1/Code/site.co.uk/vendor/assets/images
/Volumes/Storage1/Code/site.co.uk/vendor/assets/javascripts
/Volumes/Storage1/Code/site.co.uk/vendor/assets/stylesheets
/Users/user/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/chartkick-1.3.2/app/assets/javascripts
/Users/user/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/coffee-rails-4.0.1/lib/assets/javascripts
/Users/user/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/jquery-rails-3.0.4/vendor/assets/javascripts
/Users/user/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/bourbon-4.0.2/app/assets/stylesheets
/Volumes/Storage1/Code/site.co.uk/app/assets/fonts
/Volumes/Storage1/Code/site.co.uk/app/assets/svgs
/Volumes/Storage1/Code/site.co.uk/vendor/assets/components
/Users/user/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/susy-2.1.3/sass
/Users/user/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/breakpoint-2.4.5
(in /Volumes/Storage1/Code/site.co.uk/app/assets/stylesheets/application.css.sass:3)

I'm making a guess that this: /Users/user/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/breakpoint-2.4.5 is missing a /stylesheets on the end. But I could be mistaken.

@lolmaus
Copy link
Contributor

lolmaus commented Jul 28, 2014

There's a presumable typo in breakpoint.rb.

@rctneil, please test my fix with this Gemfile line:

gem 'breakpoint', :github => 'lolmaus/breakpoint', :branch => 'patch-3'

@rctneil
Copy link
Contributor Author

rctneil commented Jul 28, 2014

@lolmaus No joy with that unfortunately.

@lolmaus
Copy link
Contributor

lolmaus commented Jul 28, 2014

@rctneil, how does this line

/Users/user/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/breakpoint-2.4.5

of the error look like when you use my fix?

@rctneil
Copy link
Contributor Author

rctneil commented Jul 28, 2014

/Users/user/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/bundler/gems/breakpoint-89e84970bb71/lib/stylesheets

Unless I am thinking on the wrong lines. Doesn't it need to reference the scss file in the stylesheets directory? Maybe i'm wrong. (usually am!)

@lolmaus
Copy link
Contributor

lolmaus commented Jul 28, 2014

@rctneil, it should reference a path to look for Sass files in.

Can you please check that the path you referenced exists on your system and contains a _breakpoint.scss file?

@Snugug Snugug closed this as completed in 89e8497 Jul 28, 2014
Snugug added a commit that referenced this issue Jul 28, 2014
@lolmaus
Copy link
Contributor

lolmaus commented Jul 28, 2014

Oops, my fault this got closed automatically. Sorry for that.

@Snugug Snugug reopened this Jul 28, 2014
@rctneil
Copy link
Contributor Author

rctneil commented Jul 28, 2014

/breakpoint-2.4.5/lb/stylesheets does not exist.

/breakpoint-2.4.5/lib/breakpoint.rb does and
/breakpoint-2.4.5/stylesheets/_breakpoint.scss does

@Snugug
Copy link
Member

Snugug commented Jul 28, 2014

Just pushed 2.4.6, give that a look

@rctneil
Copy link
Contributor Author

rctneil commented Jul 28, 2014

Submitted a request to fix this.

@lolmaus
Copy link
Contributor

lolmaus commented Jul 28, 2014

I thought to do it this way, but i failed to figure out why a double ../../ is necessary.

@lolmaus
Copy link
Contributor

lolmaus commented Jul 28, 2014

@rctneil, does it work for you? The old and new version should produce identical paths, shouldn't they?

@rctneil
Copy link
Contributor Author

rctneil commented Jul 28, 2014

My active pull request here: #110 is working for me.

@mirisuzanne
Copy link

@Snugug The wiki docs still say that Compass is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants