Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add log to show the version status of cli #1393

Merged
merged 7 commits into from
May 2, 2024

Conversation

AayushSaini101
Copy link
Contributor

Resolves: #1371

@AayushSaini101
Copy link
Contributor Author

image

@Shurtu-gal
Copy link
Collaborator

@AayushSaini101 I suppose it the message should be infrequent so as not to bother users.

@AayushSaini101
Copy link
Contributor Author

@AayushSaini101 I suppose it the message should be infrequent so as not to bother users.

@Shurtu-gal Thanks, used the probaility method to show the message when the probaility is less than 0.5.

Sample Testing of message:

Screenshot 2024-04-27 at 10 05 09 AM

@Amzani
Copy link
Collaborator

Amzani commented Apr 29, 2024

@AayushSaini101 I suppose it the message should be infrequent so as not to bother users.

Agree, especially if we don't have (yet) an auto-update feature.

@Amzani
Copy link
Collaborator

Amzani commented Apr 29, 2024

@AayushSaini101 why not just use https://github.com/oclif/plugin-warn-if-update-available, instead of having the random check for simplicity the plugin provides a periodic check that is more common.

We can check every 24h for instance.

Some other useful plugins we can add:

@AayushSaini101
Copy link
Contributor Author

@AayushSaini101 why not just use https://github.com/oclif/plugin-warn-if-update-available, instead of having the random check for simplicity the plugin provides a periodic check that is more common.

We can check every 24h for instance.

Some other useful plugins we can add:

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding the message that we show, I am seeing the following format in a few places including Next.js, Storybook, Pnpm.

Screenshot 2024-04-29 at 11 53 10

@AayushSaini101
Copy link
Contributor Author

https://github.com/oclif/plugin-warn-if-update-available

@Amzani @KhudaDad414 Added plugin and configuration to run in 24 hour.

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Shurtu-gal Shurtu-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@AayushSaini101
Copy link
Contributor Author

/rtm

@KhudaDad414
Copy link
Member

@AayushSaini101 the tests seem to be cancelled. can you push an empty commit to re-run the tests?

Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AayushSaini101
Copy link
Contributor Author

@AayushSaini101 the tests seem to be cancelled. can you push an empty commit to re-run the tests?

Rerun @KhudaDad414

@KhudaDad414
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 8b81880 into asyncapi:master May 2, 2024
12 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Member

@peter-rr peter-rr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] Automatic Version Update Notification
6 participants