Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit testing #99

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

aeworxet
Copy link
Collaborator

This PR adds unit testing as a separate Jest test suite.

Jest's .not.toThrow() assertion was not added because TypeScript will not allow anything other than string to be passed to a function whose parameter is defined as having the type of string, anyway. The type guard typeof ref === 'string' exists for the loosely typed JavaScript only.

image

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should mix unit and integration tests in one file, but on the other hand, there are not many, and we can split them later

@derberg derberg changed the title chore: add unit testing test: add unit testing Nov 15, 2022
@aeworxet
Copy link
Collaborator Author

/rtm

@asyncapi-bot asyncapi-bot merged commit b8f68b9 into asyncapi:master Nov 15, 2022
@aeworxet aeworxet deleted the chore-add-unit-testing branch November 15, 2022 13:29
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.3.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants