Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chdir back to the starting directory before exit #167

Conversation

aeworxet
Copy link
Collaborator

This PR introduces an explicit return to the directory in which the program began execution to make its behavior more predictable, and improves the resolution of the path specified in baseDir.

Fixes #166

Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@aeworxet
Copy link
Collaborator Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 047ebcb into asyncapi:master May 27, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aeworxet aeworxet deleted the fix-chdir-back-to-the-starting-directory-before-finishing-execution branch May 27, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Bundle() does not restore CWD call when baseDir is used
3 participants