-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only bundle
function should be exposed as part of public API
#70
Labels
area/typescript
Specify what technical area given issue relates to. Its goal is to ease filtering good first issues.
bug
Something isn't working
good first issue
Good for newcomers
Comments
/gfi ts |
asyncapi-bot
added
area/typescript
Specify what technical area given issue relates to. Its goal is to ease filtering good first issues.
good first issue
Good for newcomers
labels
Oct 10, 2022
@derberg only the function sections needs to be annotated right? |
aeworxet
added a commit
to aeworxet/asyncapi-bundler
that referenced
this issue
Oct 11, 2022
Co-authored-by: Lukasz Gornicki <[email protected]>
Afaik @aeworxet is working on this one already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/typescript
Specify what technical area given issue relates to. Its goal is to ease filtering good first issues.
bug
Something isn't working
good first issue
Good for newcomers
Describe the bug
When you go to https://github.com/asyncapi/bundler/blob/master/API.md#functions you see some internal functions in the API that users can use. But we should expose only
bundle
Expected behavior
All functions other than
bundle
should be annotated as private, so they do not show up in the APIThe text was updated successfully, but these errors were encountered: