Changed the shouldExpand behavior to set the layout at the time the tab is added #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ab is added rather than in onMeasure to solve some problems observed on Android < 4.3
|
astuetz ! Thank you so much.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android versions prior to 4.3 I observed a behavior in my app where the shouldExpand had no effect other than dropping the tabPadding. By moving the application of the expandedTabLayout instead of defaultTabLayout to the tab adding code as opposed to onMeasure code I was able to resolve the issue. The downside is that #42 is incompatible with this change as the weight can't be assigned beforehand.
See below for the illustration of the problem. With the fix both 4.0.3 and 4.3 behavior is the same for expansion.