Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Changes to FivetranSensor for supporting backfills #58

Merged
merged 10 commits into from
Nov 6, 2023
Prev Previous commit
Next Next commit
make always_wait_when_syncing default to false
  • Loading branch information
dwreeves committed Sep 30, 2023
commit 843582855cf52a67c94c876c826a7d25c29b7531
6 changes: 3 additions & 3 deletions fivetran_provider_async/hooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ def is_synced_after_target_time(
connector_id: str,
completed_after_time: datetime,
reschedule_wait_time: int | None = None,
always_wait_when_syncing: bool = True,
always_wait_when_syncing: bool = False,
propagate_failures_forward: bool = True,
) -> bool:
"""
Expand Down Expand Up @@ -447,7 +447,7 @@ def _determine_if_synced_from_connector_details(
connector_details: dict[str, Any],
completed_after_time: datetime,
reschedule_wait_time: int | None = None,
always_wait_when_syncing: bool = True,
always_wait_when_syncing: bool = False,
propagate_failures_forward: bool = True,
):
dwreeves marked this conversation as resolved.
Show resolved Hide resolved
succeeded_at = self._parse_timestamp(connector_details["succeeded_at"])
Expand Down Expand Up @@ -691,7 +691,7 @@ async def is_synced_after_target_time_async(
connector_id: str,
completed_after_time: datetime,
reschedule_wait_time: int | None = None,
always_wait_when_syncing: bool = True,
always_wait_when_syncing: bool = False,
propagate_failures_forward: bool = True,
) -> str:
"""
Expand Down
2 changes: 1 addition & 1 deletion fivetran_provider_async/sensors.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def __init__(
fivetran_retry_delay: int = 1,
completed_after_time: str | datetime | None = None,
reschedule_wait_time: int | None = None,
always_wait_when_syncing: bool = True,
always_wait_when_syncing: bool = False,
propagate_failures_forward: bool = False,
deferrable: bool = True,
**kwargs: Any,
Expand Down
Loading