Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hot reloading, support normal case methods, generate requirements.txt at build time, update readme #6

Merged
merged 8 commits into from
May 22, 2023
Merged

Add Hot reloading, support normal case methods, generate requirements.txt at build time, update readme #6

merged 8 commits into from
May 22, 2023

Conversation

Mohamed-Kaizen
Copy link

No description provided.

@astrojarred
Copy link
Owner

Thanks for the awesome PR @Mohamed-Kaizen! Will take a look soon.

@astrojarred
Copy link
Owner

Really great PR, thank you. Hot reloading works like a charm, incredible work!

Just made a few small changes to the other parts:

  • Had to remove the auto generation of requirements.txt for now. My Vercel build system doesn't have access to Poetry. Perhaps we can add an installation step somehow but let's open up a new issue for this.
  • I'm OK with accepting both upper or lowercase endpoints. I added a check to make sure there are no duplicates and simplified the code a bit.

LGTM!

@astrojarred astrojarred merged commit 6971021 into astrojarred:main May 22, 2023
@astrojarred astrojarred mentioned this pull request May 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mohamed-Kaizen @astrojarred